Add JS file extension to switch to controller action from view#49
Open
monavari-lebrecht wants to merge 1 commit intoapazureck:masterfrom
Open
Add JS file extension to switch to controller action from view#49monavari-lebrecht wants to merge 1 commit intoapazureck:masterfrom
monavari-lebrecht wants to merge 1 commit intoapazureck:masterfrom
Conversation
monavari-lebrecht
commented
Oct 23, 2018
- change glob pattern to match js files too
- change glob pattern to match js files too
Owner
|
Thank you for your PR. As you can see I did not update this repo for a long time. Could you check out the development branch, which was meant for the last release and see if the fix will apply there, too. The last thing I know was that I planned to remove all JS functionallity / split it up in favor of using the typescript compiler to get a better result when using UI5 with Typescript. So I guess the approach will differ from there. But I could release this as a patch as is. If you plan to contribute further, then please check out the dev branch. I hope to get back on this project in the near future, but until then it is a bit of the mess it is right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.