Fix indifferent attribute access#54
Open
akoltun wants to merge 2 commits intoapotonick:masterfrom
akoltun:fix-indifferent-attribute-access
Open
Fix indifferent attribute access#54akoltun wants to merge 2 commits intoapotonick:masterfrom akoltun:fix-indifferent-attribute-access
akoltun wants to merge 2 commits intoapotonick:masterfrom
akoltun:fix-indifferent-attribute-access
Conversation
added 2 commits
November 7, 2016 14:20
…:Property::Struct module. Model attribute which name is specified by String and value is equal to false returns nil value instead of false value.
…ecified by String and value is equal to false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code has been used in the
Disposable::Twin::Property::Struct#read_value_forto read the attribute value from the model:@model[name.to_s] || @model[name.to_sym]If the model is a Hash with string keys and the attribute value is false the left part will be false and the result will be equal to the right part which is nil since hash keys are strings but not symbols.