Add latest Rubies and Rails to CI matrix#98
Add latest Rubies and Rails to CI matrix#98willnet wants to merge 6 commits intoapotonick:masterfrom
Conversation
Also update actions/checkout
|
Hi @apotonick—could you review this PR when you can? Thanks! |
test/test_helper.rb
Outdated
| # Ruby 3.4 changed from {:key => value} to {key: value} in inspect output | ||
| def normalize_inspect(inspect_string) | ||
| inspect_string | ||
| .gsub(/" => /, '"=>') # Remove spaces around => for string keys: "key" => value → "key"=>value |
There was a problem hiding this comment.
Cool, we have this https://github.com/trailblazer/trailblazer-core-utils/blob/master/lib/trailblazer/core/utils/inspect.rb#L14 which we could use here, but I will test your version! 💚
Would you mind making the tests assert_equal asserted, expected?
There was a problem hiding this comment.
For now, I changed only the parts related to this diff to use the assert_equal expected, actual format. Let me know if you want me to update all the other tests as well.
There was a problem hiding this comment.
Hi @willnet, thanks! I tested your gsub magic! 🎉 I will release trailblazer-core-utils soon and we can start using our inspect helper here. Are you happy to change the tests accordingly?
|
@apotonick I also added Ruby 4.0 and Rails 8.1 to the CI. |
2 participants
Add the latest Rails and Ruby to the CI matrix. CI then failed, so I made the following changes to get the tests passing:
CI result is here.