Add releaseNetwork method to ContainerManager#527
Merged
dcantah merged 2 commits intoapple:mainfrom Feb 12, 2026
Merged
Conversation
Decompose delete() into release() + file removal. The new release() method frees network resources for a container without deleting its files, enabling stop-and-restart workflows that preserve the rootfs.
dcantah
reviewed
Feb 11, 2026
| /// | ||
| /// - Parameter id: The container ID. | ||
| public mutating func delete(_ id: String) throws { | ||
| public mutating func release(_ id: String) throws { |
Member
There was a problem hiding this comment.
I'd prefer if this was releaseNetwork honestly
Contributor
Author
There was a problem hiding this comment.
Okay, I've renamed it.
DePasqualeOrg
changed the title
release method to ContainerManagerreleaseNetwork method to ContainerManager
dcantah
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've extracted the network cleanup step from
deleteinto a new publicreleaseNetworkmethod. This mirrors the existingreleaseonVmnetNetworkand enables stop-and-restart workflows where the network allocation needs to be freed without removing the container's rootfs.Changes
ContainerManager.release(_:)— frees network resources for a container after it has stoppeddelete(_:)to callreleaseNetwork(_:)before removing files, preserving existing behaviorMotivation
Currently the only way to free a container's network allocation is
delete, which also removes its files. This makes it impossible to stop a container (freeing the network so the ID can be re-allocated) and later restart it with its filesystem intact. The newreleaseNetworkmethod fills this gap.