Open
Conversation
This adds a small flag named --log-level to be able to set the log level of vminitd and the pause command. I imagine this won't be the last time we'll have to add flags to vminitd so I went ahead and converted vminitd to be a Argument Parser based binary as well.
| static let configuration = CommandConfiguration( | ||
| commandName: "vminitd", | ||
| abstract: "Virtual machine init daemon", | ||
| version: "0.1.0", |
Contributor
There was a problem hiding this comment.
Should this be the version of the previous tag + commit info if not at a tagged commit?
Member
Author
There was a problem hiding this comment.
We could, I'm not too worried about the version at the moment
| try await InitCommand.run(log: log) | ||
| var command = try parseAsRoot() | ||
| if let asyncCommand = command as? AsyncParsableCommand { | ||
| nonisolated(unsafe) var unsafeCommand = asyncCommand |
Contributor
There was a problem hiding this comment.
why does this need to be an unsafe variable?
katiewasnothere
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a small flag named --log-level to be able to set the log level of vminitd and the pause command. I imagine this won't be the last time we'll have to add flags to vminitd so I went ahead and converted vminitd to be a Argument Parser based binary as well.