Add inequality operator ( != ) for digest and DataProtocol comparison#180
Open
joey-gm wants to merge 2 commits intoapple:mainfrom
Open
Add inequality operator ( != ) for digest and DataProtocol comparison#180joey-gm wants to merge 2 commits intoapple:mainfrom
joey-gm wants to merge 2 commits intoapple:mainfrom
Conversation
Lukasa
requested changes
Apr 24, 2023
Contributor
Lukasa
left a comment
There was a problem hiding this comment.
Thanks for this! As with several other PRs open on this repo, any change to the public API surface requires synchronization with CryptoKit in Apple's SDKs. While this is a reasonable change, I'm going to defer merging it for now.
fepimentel
approved these changes
Apr 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an inequality comparison operator to determine whether a digest is not equal to a collection of contiguous bytes.
Checklist
Motivation:
The equal ( == ) and not equal ( != ) operators are available for comparing two digests. However, only the equal operator is available for the comparison between a digest and a collection of contiguous bytes.
This modification adds the missing inequality operator ( != ) for digest and DataProtocol comparison.
Modifications:
The following static method has been added to Digest.swift as an extension to Digest.
public static func != <D: DataProtocol>(lhs: Self, rhs: D) -> BoolA corresponding test case has also been added to DigestsTests.swift.
Result:
Instead of checking
if !(digest == someDataBytes) {...}, we can now writeif digest != someDataBytes {...}.