Fix RSA.Encryption.PublicKey unsafePEMRepresentation incorrect keySizeInBits #234
Open
anotheren wants to merge 2 commits intoapple:mainfrom
Open
Fix RSA.Encryption.PublicKey unsafePEMRepresentation incorrect keySizeInBits #234anotheren wants to merge 2 commits intoapple:mainfrom
anotheren wants to merge 2 commits intoapple:mainfrom
Conversation
…ect keySizeInBits check
Lukasa
reviewed
May 28, 2024
Contributor
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
Thanks, this is a really good catch. Are you interested in adding a quick unit test to prevent further regression?
Author
|
Just added. |
Contributor
|
@swift-server-bot test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 3.4, the
_RSA.Encryption.PublicKeyintroduced a set of unsafe APIs to handle cases wherekeySizeInBitsis less than 2048. However, in the implementation, the boundary check forkeySizeInBitsininit(unsafePEMRepresentation:)was incorrectly set asself.keySizeInBits >= 2048. Similar APIs indicate that it should actually beself.keySizeInBits >= 1024. This PR attempts to correct this issue.