Skip to content

fix the pinning api filtering#992

Open
ohmpatel1997 wants to merge 2 commits intoapplication-research:devfrom
ohmpatel1997:pinning_status_fix
Open

fix the pinning api filtering#992
ohmpatel1997 wants to merge 2 commits intoapplication-research:devfrom
ohmpatel1997:pinning_status_fix

Conversation

@ohmpatel1997
Copy link

@ohmpatel1997 ohmpatel1997 commented Jul 14, 2023

  • This PR fixes the status based filtering on the list pins api.

@LucRoy LucRoy requested review from LucRoy and alvin-reyes July 19, 2023 16:41
@LucRoy LucRoy added the Improvement Improve a feature or the codebase label Jul 19, 2023
@LucRoy
Copy link
Contributor

LucRoy commented Jul 19, 2023

I'm wondering if we shouldn't add either a new endpoint or new query param for this. We want to make sure we don't break any backward compatibility. @alvin-reyes what do you think?

@ohmpatel1997
Copy link
Author

make sure we don't break any backw

I think the previous logic was flawed in itself. So even if someone was using it must be giving them the wrong results. also it wont break any existing api's schema, since we are not chaning any query param types.

@ohmpatel1997
Copy link
Author

Hi @LucRoy can we please get this PR in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Improve a feature or the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants