fix the pinning api filtering#992
Open
ohmpatel1997 wants to merge 2 commits intoapplication-research:devfrom
Open
fix the pinning api filtering#992ohmpatel1997 wants to merge 2 commits intoapplication-research:devfrom
ohmpatel1997 wants to merge 2 commits intoapplication-research:devfrom
Conversation
Contributor
|
I'm wondering if we shouldn't add either a new endpoint or new query param for this. We want to make sure we don't break any backward compatibility. @alvin-reyes what do you think? |
Author
I think the previous logic was flawed in itself. So even if someone was using it must be giving them the wrong results. also it wont break any existing api's schema, since we are not chaning any query param types. |
Author
|
Hi @LucRoy can we please get this PR in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.