feat: disable triggerBigSync

[laggingreflex]

Lets you add an option "triggerBigSync": false in project conf to disable doing a big rsync.

fixes #79

[coveralls]

Coverage increased (+0.04%) to 97.357% when pulling 76b5f7d on laggingreflex:feat/disable-bigSync into 00dc1a8 on appnexus:master.

[joelgriffith]

Since you're adding a new field to the project configuration, could also add the appropriate prompt when setting up a new project? Should be in: https://github.com/appnexus/sicksync/blob/master/src/project-helper.js#L18

[joelgriffith]

Can probably just do if (projectConf.triggerBigSync) {. Older configurations won't have this definition, and will returnundefined, which is falsy.

[laggingreflex]

I'm checking for not false. If older config has it undefined then this would be true which is the current default behavior. if (projectConf.triggerBigSync) { would disable it for all older configs that have it undefined.

[laggingreflex]

Should it better be labeled as something like disableRsync which would be totally new option and not break any previous config?

[laggingreflex]

I've updated it to be a --disable-rsync cli arg and disableRsync as project config

I've also update the --no-delete cli arg I added earlier to be --disable-deletion cli arg and disableDeleteion project arg

[coveralls]

Coverage decreased (-0.4%) to 96.957% when pulling bbf9754 on laggingreflex:feat/disable-bigSync into 00dc1a8 on appnexus:master.

[laggingreflex]

I'm currently testing it out and having some issues.

Don't merge it yet, I'll let you know when. Sorry for hasty commits.

[coveralls]

Coverage decreased (-0.4%) to 96.957% when pulling 5e1635b on laggingreflex:feat/disable-bigSync into 00dc1a8 on appnexus:master.

[coveralls]

Coverage decreased (-0.4%) to 96.97% when pulling b861ede on laggingreflex:feat/disable-bigSync into 00dc1a8 on appnexus:master.

[laggingreflex]

I was forgetting about a particular callback which was causing the issue. Wrapping triggerBigSync in an if just like that was not a great idea:

if(..) {
  triggerBigSync(projectConf, { debug: config.debug }, () => {
    localLog(text.SYNC_ON_LARGE_CHANGE_DONE);
    fsHelper.watch();
  });
}

There's a callback there which wouldn't get called.

I've used async/await now (added a babel-preset-stage-0) with which it could be solved and simplified:

if (...) {
  await triggerBigSync(projectConf, { debug: config.debug });
}
localLog(text.SYNC_ON_LARGE_CHANGE_DONE);
fsHelper.watch();

Although it alters the API a bit (triggerBigSync now returns a promise) so some tests might be failing. I'll see if I can work on those later in the week. Feel free to review now.

[coveralls]

Coverage increased (+0.05%) to 96.97% when pulling 0a7dffa on laggingreflex:feat/disable-bigSync into af55b54 on appnexus:master.

[joelgriffith]

nice!

[joelgriffith]

This looks great, we'll see what the CI finds test wise.

[coveralls]

Coverage increased (+0.05%) to 96.97% when pulling 0a7dffa on laggingreflex:feat/disable-bigSync into af55b54 on appnexus:master.

[coveralls]

Coverage increased (+0.05%) to 96.97% when pulling 6165fbf on laggingreflex:feat/disable-bigSync into af55b54 on appnexus:master.

[joelgriffith]

I just pushed some updates to get tests running (properly) again, sorry for the thrash. I can update your PR to resolve the conflicts here on Friday.