-
Notifications
You must be signed in to change notification settings - Fork 186
fixed "Get started" button fully not seen issue in hero section. #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+7
−4
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency between commit message and implementation; redundant animation props.
The commit message states "Fix LCP by removing animation from H1," but the h1 is still animated through the motion.div wrapper. Animating the LCP element (typically the main heading) delays when the browser considers it painted, negatively impacting the LCP metric.
Additionally, the motion.div has redundant animation props: when using
variants={itemVariants}that already define "hidden" and "visible" states, the explicitinitial="hidden"andanimate="visible"props are unnecessary. The parent container at line 49 already orchestrates staggered animations throughcontainerVariants.If the goal is to improve LCP performance, remove the animation entirely from the h1 block. Otherwise, simplify by removing the redundant
initialandanimateprops.🔎 Proposed fix to remove animation for LCP improvement
If the goal is to improve LCP, remove the motion.div wrapper:
Alternatively, if animation is desired, remove the redundant props:
📝 Committable suggestion
🤖 Prompt for AI Agents