Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the documentation and codebase to improve security and maintainability in the upload handling system. The most significant change is the switch from sequential integer upload IDs to random, URL-safe string
public_ids for uploads, which affects both the API documentation and backend logic. Additionally, the cleanup logic in the backend is refactored for clarity and better type safety, and some CLI utilities are improved for usability and maintainability.API and Documentation Updates:
public_id(an 18-character URL-safe random string) instead of integer IDs for uploads.Backend Cleanup Logic Refactoring:
backend/app/cleanup.pyto:CLI Improvements:
parse_sizefunction to a shared utility module and improved error handling for invalid size inputs in CLI commands.