Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the backend embed preview logic, introduces a new static embed endpoint, improves multimedia preview rendering for users, and enhances the frontend admin tokens table with better mobile support and loading states. It also includes minor fixes and new tests for embed previews.
Backend: Embed Preview Refactor and Static Embed Endpoint
embed_preview.py) for better reusability, including bot detection and rendering functions./e/{token}endpoint (token_embed) that renders a static multimedia preview for a shared token, always showing the preview to users (not just bots)./f/{token}to delegate bot detection and preview rendering to the new module, simplifying the route and ensuring consistent behavior. [1] [2]Frontend: Admin Tokens Table Improvements
AdminTokensTable.vuecomponent to support a responsive, card-based mobile layout and added loading/empty states for better UX. [1] [2] [3]Embed Preview Rendering Enhancements
share_preview.htmlto show fullscreen video/audio previews for user requests on the new static embed endpoint, improving the viewing experience. [1] [2] [3]Testing and Configuration
/e/{token}endpoint to ensure it renders the correct preview for public tokens.FBC_ALLOW_PUBLIC_DOWNLOADS=0in test config to avoid side effects in test environments.Other Fixes
ensure_faststart_mp4utility for more reliable MP4 processing. [1] [2]