Updated project settings, int -> NSInteger, fixed warnings and deprecations#119
Updated project settings, int -> NSInteger, fixed warnings and deprecations#119shazron wants to merge 2 commits intoarauchfuss:masterfrom
Conversation
…ations int -> NSInteger, intValue -> integerValue Added imageUTIs, imageExtensionsFromUTIs methods
|
|
||
| off_t extractsize,totalsize; | ||
| int extractingentry; | ||
| NSInteger extractingentry; |
There was a problem hiding this comment.
It doesn't look like you updated the XADMaster library itself. Editing headers of compiled libraries must be done with care.
Good news is that XADMaster (or a previous version of it) is open-source.
There was a problem hiding this comment.
Oops yeah this was a general copy and replace mostly, I will revert changes from the Frameworks folder. I see several mirrors/forks of XADMaster, which one does Simple Comic derive the framework from? Any others that I should look at with this code review? Thanks!
There was a problem hiding this comment.
Looks like 2 files need to be reverted:
- Frameworks/XADMaster.framework/Versions/A/Headers/CSInputBuffer.h
- Frameworks/XADMaster.framework/Versions/A/Headers/XADArchive.h
I found this to be the official repo: https://github.com/MacPaw/XADMaster
|
Added commit to revert unwanted changes in |
2 participants
imageFileTypes. Replacement methodimageTypesreturnsutisnow)