fix: update Google Workspace MCP catalog entry to use original repo#369
fix: update Google Workspace MCP catalog entry to use original repo#369Aqil-Ahmad wants to merge 9 commits intoarchestra-ai:mainfrom
Conversation
|
@Aqil-Ahmad is attempting to deploy a commit to the Archestra projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
Updates MCP catalog data to reference the original Google Workspace MCP repository, and adjusts catalog tooling/schema handling to avoid a Zod schema shape access crash.
Changes:
- Switch Google Workspace MCP catalog references from
iskhakov/google_workspace_mcptotaylorwilsdon/google_workspace_mcpand simplify its server invocation/env. - Fix
McpbManifestSchema.shapecrash by unwrapping the inner schema before building the derived manifest schema. - Rename the Archestra coding agent catalog entry and update the catalog server list accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| app/app/mcp-catalog/schemas.ts | Unwraps refined McpbManifestSchema to access object shape for derived schema construction. |
| app/app/mcp-catalog/data/mcp-servers.json | Updates catalog server URL entries (Google Workspace + Archestra coding agent). |
| app/app/mcp-catalog/data/mcp-evaluations/taylorwilsdon__google_workspace_mcp.json | Updates evaluation metadata/installation args to match the original upstream repo. |
| app/app/mcp-catalog/data/mcp-evaluations/archestra-ai__archestra-coding-agent.json | Renames the evaluation name to the canonical owner__repo form. |
|
@joeyorlando please review! also i've made some unrelated changes but those were needed. |
Recording.2026-02-17.022831.mp4Recording.2026-02-17.023001.mp4 |
joeyorlando
left a comment
There was a problem hiding this comment.
Thanks for tackling this @Aqil-Ahmad! The core fix (switching to the original taylorwilsdon repo and removing the problematic flags/env vars) looks correct and should resolve #2717. A few things to address though:
schemas.ts change is breaking CI
All three CI jobs are failing with TypeError: Right-hand side of 'instanceof' is not an object. This project uses Zod v4 (^4.3.6), which doesn't export ZodEffects or ZodObject as classes — so instanceof z.ZodEffects / instanceof z.ZodObject doesn't work. That's a Zod v3 pattern.
Since McpbManifestSchema.shape works fine on main today, I'd recommend dropping this change entirely from this PR. If it does become a problem in the future (e.g. after a @anthropic-ai/mcpb upgrade), we can address it in a separate PR with a Zod v4-compatible approach.
Unrelated changes
The coding agent rename ("coding" → full GitHub URL) and the evaluation name field change are unrelated to the Google Workspace fix. Could you split those into a separate PR to keep this one focused on the bug fix?
Evaluation data
The evaluation file was renamed from iskhakov__* to taylorwilsdon__*, but the GitHub metrics inside (stars, contributors, etc.) still reflect the old fork's data. Worth re-running pnpm catalog:evaluate against the taylorwilsdon repo to get accurate numbers.
TL;DR — to get this mergeable:
- Revert the
schemas.tschanges - Split out the coding agent rename into its own PR
- Consider re-running evaluation for the new repo
joeyorlando
left a comment
There was a problem hiding this comment.
Looks great now! All previous feedback addressed:
- schemas.ts and coding agent changes reverted — PR is focused on the Google Workspace fix only
- Evaluation re-run with fresh metrics from the taylorwilsdon repo (1418 stars, 67 contributors — much more accurate)
- CI is all green
Thanks for iterating on this @Aqil-Ahmad!
…bsite into googleWorkspaceMCP
fixes #archestra-ai/archestra#2717
Summary
iskhakov/google_workspace_mcpto originaltaylorwilsdon/google_workspace_mcp--transport streamable-httpflagunrelated changes:
McpbManifestSchema.shapecrash inschemas.tsby unwrapping ZodEffects to inner ZodObject/claim #archestra-ai/archestra#2717