Add --rotate that gets passed to flutter-pi#54
Add --rotate that gets passed to flutter-pi#54Levi-Lesches wants to merge 3 commits intoardera:mainfrom
--rotate that gets passed to flutter-pi#54Conversation
ardera
left a comment
ardera
left a comment
There was a problem hiding this comment.
In general, looks good! Just the FlutterPiToolConfig thing.
What would also be good is if you could specify a rotation when adding a device, since people are probably not rotating their Pi in new ways every time they're launching an app, but rather have a single fixed rotation they want to use for a device (Having the arg for the run command is still useful, since you might want to override)
| required this.fs, | ||
| required this.logger, | ||
| required this.platform, | ||
| required this.rotation, |
There was a problem hiding this comment.
Sorry this isn't really clear in the code, but the FlutterPiToolConfig class basically represents the persistent configuration file of the flutterpi_tool, where the devices and their options are stored. I think the rotation might be better fit somewhere else
| final Logger logger; | ||
| final FlutterpiCache cache; | ||
| final MoreOperatingSystemUtils os; | ||
| final FlutterPiToolConfig config; |
There was a problem hiding this comment.
See above, maybe instead introduce a final int? rotation member instead, just like the explicitDevicePixelRatio and explicitDisplaySizeMillimeters.
|
@ardera Please add the rotation functionality. |
|
Any updates on this pr? |
|
Closed in favor of the now merged #83 |
4 participants
Adds a new
-r--rotationargument toflutterpi_tool runthat mirrorsflutter-piCloses #44