Eliminate need for multiple calls to nondeterministic millis() when getting individual day/time components#141
Open
LeonPoon wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Conversation
|
|
LeonPoon
changed the title
…etting individual day/time components
Author
|
Would appreciate feedback, or a merge please. I encountered one instance when the getHours and getMinutes don't provide consistent results, because of each of these make calls to millis() on their own, which might not return the same value. It was 8:59++ and getHours() returned 8 but getMinutes returned 0 and my datalogger recorded time as 8:00 when it was actually closer to 9:00. With this patch, allows me to provide same millis input to gethours/minutes rather than having these get functions call their own millis(). thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also eliminated some dup calc code between getHours/Minutes/Seconds and getFormattedTime.
Fully backwards compatible.