Add packet validity checks#145
Draft
bmcdonnell wants to merge 2 commits intoarduino-libraries:masterfrom
Draft
Conversation
|
|
|
Memory usage change @ cb073ba
Click for full report table
Click for full report CSV |
bmcdonnell
force-pushed
the
add-packet-validity-checks
branch
from
cb073ba to
38a7dff
Compare
Author
|
I added a check of the fractional part of the reference time, since per RFC4330,
This time does roll over, so it can hit zero again. The reference time isn't updated frequently - it's not always getting updated in subsequent queries like the other timestamps - so this force push covers a very rare but still conceivable corner case (vs the previous revision). |
Author
|
Marked as draft because I'm getting some NTP version 3 responses, which this was rejecting. |
|
Memory usage change @ 38a7dff
Click for full report table
Click for full report CSV |
per1234
added
type: imperfection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #133. Improves upon #28 (not merged).