Added getFormattedDateTime method#207
Open
leodrivera wants to merge 6 commits intoarduino-libraries:masterfrom
Open
Added getFormattedDateTime method#207leodrivera wants to merge 6 commits intoarduino-libraries:masterfrom
leodrivera wants to merge 6 commits intoarduino-libraries:masterfrom
Conversation
4c44ac0 to
3b359eb
Compare
|
Memory usage change @ 3b359eb
Click for full report table
Click for full report CSV |
a71b16c to
5b5c317
Compare
|
Memory usage change @ 5b5c317
Click for full report table
Click for full report CSV |
This was
linked to
issues
Jun 23, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement getFormattedDateTime, which has the advantage, when compared #94 that does not rely on external lib and parse more patterns. The #161 was used as base, however, I had to change all the calculation logic, as the results were not correct
Patterns
With this new method, getFormattedTime loses the meaning of existing, given that we can obtain the same result through the parameter "%H:%M:%S"
timeClient.getFormattedDateTime("%H:%M:%S")