Avoid board change during compilation/upload#6106
Avoid board change during compilation/upload#6106facchinm wants to merge 1 commit intoarduino:masterfrom
Conversation
By threading the boardChange callback we can busy wait until the compilation/upload phase has ended and change the board when done. Fixes arduino#6035
|
@ArduinoBot build this please |
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-678-linux32.tar.xz ℹ️ The |
|
This doesn't look like a very robust fix to me. Wouldn't it be better to refactor the verify/upload code to, when starting the verify/upload, collect all settings it needs and use these, regardless of any changes to the main settings? |
|
Not very robust in fact, but refactoring the entire code from using the properties map into local variables could be longer than expected |
|
A side effect of this patch is that bundled libraries' |
facchinm
added
the
editor-refactor
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6106-BUILD-723-linux32.tar.xz ℹ️ The |
5 participants
By threading the boardChange callback we can busy wait until
the compilation/upload phase has ended and change the board when done.
Fixes #6035