Make "find and replace" window always appear on top of the parent editor#6603
Make "find and replace" window always appear on top of the parent editor#6603facchinm wants to merge 6 commits intoarduino:masterfrom
Conversation
facchinm
added
the
Component: IDE user interface
facchinm
added
the
Help wanted
|
I'm sorry, but now I understand your reply, it is ashamed. What we want is like this picture below: |
|
Hi @czghzc , |
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6603-BUILD-732-linux32.tar.xz ℹ️ The |
|
Hi @facchinm , |
If the editor is focused, acquire alwaysOnTop capabilities but drop them as soon as both the editor and the dialog are out of focus
As implemented in Notepad++, a partially transparent search/replace window could make it easier to interact with the editor (particularly in fullscreen contexts, when the "always on top" window could hide the search results). Unfortunately, Java can only apply the transparency to undecorated window, so it's a no-go. Java gurus, please come to the rescue :D
Probably this approach could be adopted by all OSes with a little care on the window lifecycle.
cmaglie
force-pushed
the
find_replace_window_top
branch
from
09f5196 to
71418ca
Compare
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6603-BUILD-740-linux32.tar.xz ℹ️ The |
|
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6603-BUILD-742-linux32.tar.xz ℹ️ The |
|
With 6603 the behavior is noticeably better, for doggone sure! (Linux Mint) Only thing is, still, I when I file-save via the menu dropdown, the "find" window still goes behind right when I select the final menu selection and stays there. I some other menu selections do the same (some in help menu, at least), but others (save-as, for example) work the "find" window just fine. |
|
When programming in C++, setting the search window to the child window of the main window can achieve the desired effect. However, I will not use Java. I do not know if Java has the same operation method. In addition, I also have a suggestion that when the search window comes out, the content of the search text box is selected, which facilitates us to modify the content to be searched. |
|
I agree with causing the text to be selected when re-pressing ctrl-f. I just thought you had a reason for not having it that way in the first place. Otherwise oftentimes a person enters new test unintentionally appending to previous. Additionally, you could replace the text with any text currently selected in the main window, just like when the search gets newly activated. |
4 participants
Fixes #6408 and #4883