Quick Fix of overflow for larger toggle_count values#565
Open
lookfwd wants to merge 1 commit intoarduino:masterfrom
Open
Quick Fix of overflow for larger toggle_count values#565lookfwd wants to merge 1 commit intoarduino:masterfrom
lookfwd wants to merge 1 commit intoarduino:masterfrom
Conversation
Quick Fix of overflow for larger `toggle_count` values. Because of the 16-bit `int` value in many platforms including Uno, the calculation of `toggle_count` overflows easily. For example with a frequency of 39kHz and a duration of 9ms, you get `toggle_count == 112 `, which is 1.5ms.
|
Memory usage change @ bd82352
Click for full report table
Click for full report CSV |
matthijskooijman
approved these changes
Sep 3, 2024
Collaborator
matthijskooijman
left a comment
There was a problem hiding this comment.
Looks like a good fix to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick Fix of overflow for larger
toggle_countvalues. Because of the 16-bitintvalue in many platforms including Uno, the calculation oftoggle_countoverflows easily. For example with a frequency of 39kHz and a duration of 9ms, you gettoggle_count == 112, which is 1.5ms.