HID: Remove empty HID_::begin() method to simplify#570
Open
forderud wants to merge 1 commit intoarduino:masterfrom
Open
HID: Remove empty HID_::begin() method to simplify#570forderud wants to merge 1 commit intoarduino:masterfrom
forderud wants to merge 1 commit intoarduino:masterfrom
Conversation
This method doesn't do anything, so I'm proposing to remove it to make the class easier to understand for new developers.
|
Memory usage change @ ea656f1
Click for full report table
Click for full report CSV |
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method doesn't do anything, so I'm proposing to remove it to make the class easier to understand for new developers.
I'm willing to also submit PR's for also updating the corresponding implementation in the other Arduino repos (ArduinoCore-samd, ArduinoCore-sam) if desired.