This repository was archived by the owner on Oct 21, 2021. It is now read-only.
Implement inheritance through spec_dict merging in compilation#32
Open
moshewe wants to merge 3 commits intoargoproj-labs:masterfrom
Open
Implement inheritance through spec_dict merging in compilation#32moshewe wants to merge 3 commits intoargoproj-labs:masterfrom
spec_dict merging in compilation#32moshewe wants to merge 3 commits intoargoproj-labs:masterfrom
Conversation
|
|
fixed bug in spec dict merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented in
Workflow. I wasn't able to run the tests in the library (no explanation I could find on how to do that), but I've run the code with my own app and it works.I've tested it with a hierarchy of 3 classes, A->B->C, and various inheritance scenarios. E.g.,
entrypointwas defined in A, and I can now see it in the compilation result of C.Addresses #19 , but also some others I saw.