Support MethodCall in if/else branches #1177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update from main
update from master
update from main
Collaborator
|
@Turupawn getting the CI linting to pass can be a little tricky. To locally run what the CI runs, do |
Collaborator
|
Can you add a test file to crates/codegen/tests/fixtures that demonstrates the code that now passes but before didn't? |
Contributor
Author
|
@micahscopes Thank you for the heads up, I ran the formatter this time. @cburgdorf I added a demo that shows what works now. However I also discovered this issue #1185 that is currently happening in the main branch. Even though the issue is related, imo it should be treated separately. |
cburgdorf
reviewed
Dec 17, 2025
| let v1 := v0 | ||
| let v2 := 0 | ||
| if gt(x, 10) { | ||
| v2 := get_value1(v1) |
Collaborator
There was a problem hiding this comment.
It looks like the name of the functions being called get_value1 does not match the actual name of the function teststruct_get_value1
Update from main
…mir-testground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MethodCallis now supported in if/else branches as returned valeslower_and_format_callfunction to encapsulate repeated code