doc engine #1179
Draft
doc engine #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a generic items_in_scope API to HIR that collects all visible items in a given scope across the specified name domains. This follows the same pattern as available_traits_in_scope and properly handles: - Named imports - Glob imports - Unnamed/prelude imports - Direct child items - Parent scope items (recursively) Add ScopeId::items_in_scope() as a convenient traversal-like method. Rewrite completion handler to: - Find the most specific scope at cursor position - Use items_in_scope to get properly scoped completions - Convert NameRes items to appropriate CompletionItem kinds This fixes completion showing random unrelated symbols and provides context-aware suggestions that respect lexical scope.
- Set insert_text, insert_text_format, and insert_text_mode to prevent unwanted text replacement and indentation issues - Detect when completion is triggered by '.' for future member access implementation - Add TODO for member completion (needs proper public API for type members) This fixes the issue where completion would replace existing text and add extra indentation.
Use top_mod.target_at() instead of reference_at() + target_at() so that rename works when cursor is on a definition name, not just references.
- Add textDocument/implementation handler for traits and trait methods
- On traits: navigates to all impl Trait blocks
- On trait methods: navigates to all implementations of that method
- Fix trait method rename to also rename implementations
- When renaming a trait method, all corresponding method definitions
in impl blocks are also renamed
Combines: - Advanced completions with auto-import - Signature help and code actions - Document formatting - Document/workspace symbols - Inlay hints with doc-engine features: - Live documentation server - Doc navigation and cursor following - fe doc command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on #1175