workspaces #1194
workspaces #1194
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
crates/driver/src/ingot_handler.rs
Outdated
| version, | ||
| }); | ||
| return None; | ||
| } | ||
|
|
There was a problem hiding this comment.
When a dependency specifies both name and version, convert_dependency short-circuits to a workspace registry lookup and immediately reports IngotByNameResolutionFailed/return None if the pair is not already registered, bypassing the subsequent location-based resolution. Because metadata is only registered for the current ingot as it is being processed, a workspace member that depends on another member by name+version will fail whenever the target ingot has not been resolved yet, even if a valid path/location was provided. This makes name+version dependencies unusable unless every member is pre-registered in the workspace manifest.
Useful? React with 👍 / 👎.
1 participant
No description provided.