perf: Move sync push from save() to command layer #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
save() no longer triggers network sync. SyncPush() is called once at command end (CLI) or on TUI exit, reducing network round-trips from N-per-session to 1. Co-Authored-By: Claude <noreply@anthropic.com>
Demonstrates save() has zero network cost (28ms) while SyncPush() incurs the sync delay once (80ms with 200ms mock). Validates the command-layer push refactor. Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
save()so vault writes are purely local I/O (no network)SyncPush()method to VaultService, called once at command end (CLI) or TUI exitBenchmarks
save()(after)SyncPush()5 operations in TUI: ~2.1s blocking → ~540ms total.
Test plan
TestVaultSave_DoesNotTriggerPush— save() no longer calls SmartPushTestVaultSyncPush_CallsSmartPush— SyncPush() calls SmartPushTestVaultSyncPush_SkipsOnConflict— SyncPush() skips when conflict detectedBenchmarkSave_NoNetworkCost— save() completes in ~28msBenchmarkSyncPush_IncursNetworkCost— SyncPush() completes in ~80ms🤖 Generated with Claude Code