Skip to content

add CRIRES+ functionality#91

Merged
arjunsavel merged 22 commits intomainfrom
add_crires
Mar 3, 2025
Merged

add CRIRES+ functionality#91
arjunsavel merged 22 commits intomainfrom
add_crires

Conversation

@arjunsavel
Copy link
Owner

@arjunsavel arjunsavel commented Feb 26, 2025

would no longer be limited to IGRINS! addresses #66.

  • need docs — would feed in the json file.
  • also need the instrument resolution to get mapped
  • also need to add a few lines of tests.

@arjunsavel arjunsavel added the enhancement New feature or request label Feb 26, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 80.32787% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (43ec111) to head (451cc8b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/scope/noise.py 11.11% 8 Missing ⚠️
src/scope/_version.py 81.82% 2 Missing ⚠️
src/scope/run_simulation.py 93.33% 1 Missing ⚠️
src/scope/utils.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
+ Coverage   68.98%   73.80%   +4.82%     
==========================================
  Files          12       13       +1     
  Lines         893      939      +46     
==========================================
+ Hits          616      693      +77     
+ Misses        277      246      -31     
Flag Coverage Δ
unittests 73.80% <80.33%> (+4.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arjunsavel arjunsavel merged commit abee600 into main Mar 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants