Dockerfile fixes for matplotlib and cython modules#85
Open
omsai wants to merge 3 commits intoarq5x:masterfrom
Open
Dockerfile fixes for matplotlib and cython modules#85omsai wants to merge 3 commits intoarq5x:masterfrom
omsai wants to merge 3 commits intoarq5x:masterfrom
Conversation
- libfreetype6-dev satisfies the freetype requirement. - pkg-config addresses freetype detection by matplotlib (see matplotlib/matplotlib#3029).
setup.py chokes when installing more than 1 cython module. In the current requirements.txt pandas, scipy, and h5py all use cython during compilation. As a workaround, pre-install these using pip.
Author
|
Test of poretools Docker image running after the NumPy ABI fix 475a8b7. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The matplotlib fix is straight forward. For the cython errors, it may be worth keeping #84 open to find a better fix; I would be happy to investigate any suggestions. Although working around them by installing the requirements via pip at least helps the Docker image to build.