Separating content type and text encoding when constructing cached response#13
Open
mj wants to merge 6 commits intoartifacts:masterfrom
Open
Separating content type and text encoding when constructing cached response#13mj wants to merge 6 commits intoartifacts:masterfrom
mj wants to merge 6 commits intoartifacts:masterfrom
Conversation
… header is part of the MIMEType property of a NSURLResponse. Splitting the MIME type and passing the conding using textEncodingName fixes this. We probably need to figure out a more solid way to parse the MIME type.
These changes should have been part of the previous commit but somehow got lost somewhere.
|
This should be added. It worked great to eliminate the problem of UIWebview showing HTML code instead of the actual webpage due to mime types not being recognized. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While using AFCache I noticed that apparently
UIWebViewgets confused when the text encoding is part of the MIME type (aka content type) field of aNSURLResponse. This can happen when the original request was responded by a web application with e.g. the perfectly legal headerContent-type: text/html; charset=utf-8.I fixed this by implementing a simple parser for MIME types per RFC 2616 (see section 3.7) and using that one to split the content type and the text encoding.
Please let me know if you like the patch. If further works needs to be done to get this into your branch, I'd be happy to do that.