Skip to content

Fix -Wunused-private-field when building with clang-cl on Windows #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hebasto wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix -Wunused-private-field when building with clang-cl on Windows #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp-subprocess/subprocess.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,7 @@ struct ArgumentDeducer
Popen* popen_ = nullptr;
};

#ifndef __USING_WINDOWS__
/*!
* A helper class to Popen.
* This takes care of all the fork-exec logic
Expand All @@ -1190,6 +1191,7 @@ class Child
Popen* parent_ = nullptr;
int err_wr_pipe_ = -1;
};
#endif

// Fwd Decl.
class Streams;
Expand Down Expand Up @@ -1377,7 +1379,9 @@ class Popen
{
public:
friend struct detail::ArgumentDeducer;
#ifndef __USING_WINDOWS__
friend class detail::Child;
#endif

template <typename... Args>
Popen(const std::string& cmd_args, Args&& ...args):
Expand Down Expand Up @@ -1891,8 +1895,8 @@ namespace detail {
}


inline void Child::execute_child() {
#ifndef __USING_WINDOWS__
inline void Child::execute_child() {
int sys_ret = -1;
auto& stream = parent_->stream_;

Expand Down Expand Up @@ -1985,8 +1989,8 @@ namespace detail {
// Calling application would not get this
// exit failure
_exit (EXIT_FAILURE);
#endif
}
#endif


inline void Streams::setup_comm_channels()
Expand Down