Skip to content

Refactoring test#149

Merged
askdkc merged 2 commits intomainfrom
refactoring-test
Feb 26, 2025
Merged

Refactoring test#149
askdkc merged 2 commits intomainfrom
refactoring-test

Conversation

@askdkc
Copy link
Owner

@askdkc askdkc commented Feb 26, 2025

testbench-coreでLaravel 12は.envconfig/app.phpがlaravel/laravelとlaravel/frameworkとで同一だから無問題なのだが、Laravel 11は.envconfig/app.phpがlaravel/laravelとlaravel/frameworkとで異なる問題がある

なのでLaravel12は普通のテストにリファクタリング可能だが、Laravel 11は11用のconfig/app.phpをテスト環境のスケルトンに準備する動きをそのままとする

@what-the-diff
Copy link

what-the-diff bot commented Feb 26, 2025

PR Summary

  • Simplified File Handling for Different Laravel Versions
    We removed a section from our code that was previously required for different Laravel versions (12 and below). This streamlines the process and makes things simpler.

  • Easier app.php File Creation
    We've enhanced how we create an app.php file. Now, the system consistently copies this from the laravel11/app.php file, resulting in a more efficient process.

  • Locale Reset Code Removal from config/app.php
    Code responsible for resetting the locale to English ('en') in the config/app.php file has been taken out. This could possibly lead to a more personalized usage experience, according to the user’s locale preference.

@askdkc askdkc merged commit 883412c into main Feb 26, 2025
9 checks passed
@askdkc askdkc deleted the refactoring-test branch February 26, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant