Open
Conversation
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This refactoring might have a performance impact (cannot measure). With this patch, the return value in the `filter()` function is not a `String` anymore, but a list of references: `Vec<&str>`. Previously, the `String` was only processed further if it was non-empty. An empty Vec<&str> is the same as an empty `String`: Not relevant for further processing. Hence, we can optimize this and join the `Vec<&str>` to `String` only if it is not empty. Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #11 I guess (the PR branch is based on the PR branch from #11)
Please review carefully and also see the commit message of the last commit for a rationale.