added support for reywood:publish-composite#191
Open
thosmos wants to merge 1 commit intoaslagle:filter-enhancementsfrom
Open
added support for reywood:publish-composite#191thosmos wants to merge 1 commit intoaslagle:filter-enhancementsfrom
thosmos wants to merge 1 commit intoaslagle:filter-enhancementsfrom
Conversation
Owner
|
Hey, sorry it took me so long to look at this :) I see the usefulness, but I'm not confident it won't cause other problems. Not sure if it's possible but I'd prefer a way to be compatible without depending on publishComposite internally. It looks it's currently publishing the cursor twice - inside ReactiveTable.publish and then again from inside publishComposite. It probably doesn't break anything, but it's weird :) This pr also isn't currently backwards-compatible since it breaks if the settings argument isn't passed in. It fails almost all the server-side tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.