MAINT: update urls and response parsing for imcce#3286
Draft
bsipocz wants to merge 5 commits intoastropy:mainfrom
Draft
MAINT: update urls and response parsing for imcce#3286bsipocz wants to merge 5 commits intoastropy:mainfrom
bsipocz wants to merge 5 commits intoastropy:mainfrom
Conversation
Member
Author
|
Maybe I should separate out the skybot part, so the update and fix for #3301 would not be blocked with miriad API issues) |
67da3bc to
c81a896
Compare
…es the different response format
c81a896 to
e82607e
Compare
This was referenced Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to address the issue #3282
The skybot part is trivial, however the response have changed for miriade and there are a multitude of issues:
Overall a lot of manual massaging and parsing is needed as some of the fields are not parsed properly by the votable parser in astropy. I've opened some new issues and commented on old ones, but I would not hold my breath and we need a workaround here sooner than any of this would be fixed upstream.
cc @darkmoloko for the issues above, and also to double check the code. However I haven't fixed all of 3) as the outputs just don't look right, so first I would need a confirmation that they are legit.