Bugfix: ALMA enhanced tables don't need qtable#3395
Draft
keflavich wants to merge 1 commit intoastropy:mainfrom
Draft
Bugfix: ALMA enhanced tables don't need qtable#3395keflavich wants to merge 1 commit intoastropy:mainfrom
keflavich wants to merge 1 commit intoastropy:mainfrom
Conversation
Member
|
Wow, how does this not raise an error, is it not covered by tests? |
bsipocz
reviewed
Aug 14, 2025
Member
bsipocz
left a comment
There was a problem hiding this comment.
Just guessing around what the problems might be
| raise | ||
|
|
||
| def _parse_stcs_string(input): | ||
| def s_region_parser(input): |
Member
There was a problem hiding this comment.
I would leave this as a private method
| return prep_table | ||
|
|
||
| for row in result: | ||
| row['s_region'] = s_region_parser(row['s_region']) |
Member
There was a problem hiding this comment.
don't reuse/call the method inside its body
| return result | ||
| else: | ||
| return _get_region(s_region.split()) | ||
| prep_table = result.to_qtable() |
Member
There was a problem hiding this comment.
I'm not at all sure why this stopped working, we haven't really switch the API (as we haven't really switched out the TAP results to return Tables rather than DAL result tables as suggested #3244)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example results in an error:
error:
This PR fixes the problem by skipping the
to_qtableconversion.However, the test is failing:
so I've not clearly solved the problem.
@andamian can you chime in?