MAST: Enable cloud dataset by default#3534
Open
snbianco wants to merge 3 commits intoastropy:mainfrom
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3534 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 219 219
Lines 20473 20528 +55
=======================================
+ Hits 14886 14927 +41
- Misses 5587 5601 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
enable_cloud_datasetfunction before they use any cloud-related functions.Proposed Behavior
enable_cloud_dataset.disable_cloud_datasetfunction.Advantages
What Changes for Users?
enable_cloud_datasetexplicitlyboto3,botocore)Other Things to Note
download_file,download_products,get_cloud_uri(s))botocore, an optional package, is imported without a guard. Now, bothboto3andbotocoreare imported with try blocks andImportErroris properly handled.Observationsinternally keeps track of whether the cloud dataset is explicitly enabled or disabled. If not explicitly enabled by the user (they callenable_cloud_dataset), warning messages are not logged when a product cannot be found in the cloud and the download falls back to on-prem. This is to avoid clogging up the console and introducing warning messages where there were none before.Close #3546