Esa gaia issue1325 cone search and query object#3539
Esa gaia issue1325 cone search and query object#3539Enriquerzrz wants to merge 4 commits intoastropy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3539 +/- ##
=======================================
Coverage 72.66% 72.67%
=======================================
Files 219 219
Lines 20478 20484 +6
=======================================
+ Hits 14880 14886 +6
Misses 5598 5598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Welcome Enrique and thank you for your PRs! |
bsipocz
left a comment
There was a problem hiding this comment.
The changes to the code looks OK. However the tests are overcomplicated and I would instead recommend to add get_query_payload to the public API which would/should return the query string instead of sending it to the server.
That would be then suitable for testing, debuging, and also would help the users.
|
Good job @Enriquerzrz ! All the checks are passing. Please have a look at the comments from @bsipocz and let us know if you have any doubt. |
|
It seems you already did it 😆 |
Hi, this is my first contribution to this repository. My name is Enrique Ruiz, and I work at Starion for ESA (SCO-08), at ESAC, mainly involved in development and maintenance of the Survey Data Archives.
This PR updates the Gaia package to enforce .14f formatting for RA/DEC/radius in cone_search and query_object, ensuring consistent ADQL queries across Python versions.
CC: @esdc-esac-esa-int
Jira: GAIAPCR-1325