EUCLID: include the new parameter linking_parameter in the method get_spectrum

[cosmoJFH]

Dear astroquery team,

we would like to update the method get_spectrum so that the spectra can be searched by a source_id (present implementation) or by a sourcepatch_id. To carry out this, we introduce the parameter linking_parameter that provides the meaning to the input id of the source.

Note that we have changed the input parameter source_id to id.

cc @esdc-esac-esa-int
jira: EUCLIDSWR-226

[codecov]

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.67%. Comparing base (20487dc) to head (21bf2c1).
⚠️ Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/esa/euclid/core.py	80.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3543      +/-   ##
==========================================
+ Coverage   72.66%   72.67%   +0.01%     
==========================================
  Files         219      219              
  Lines       20478    20493      +15     
==========================================
+ Hits        14880    14893      +13     
- Misses       5598     5600       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bsipocz]

Overall this looks good, but the argument rename will need to go through a deprecation. (it should be straightforward with the decorator though).

This also needs a changelog entry.

[bsipocz]

Unfortunately this needs to be done through an argument rename deprecation

(see usage of @deprecated_renamed_argument in e.g. the simbad module)

[cosmoJFH]

Yes, you are right. We have included it

@deprecated_renamed_argument('source_id', 'id',since='0.4.12')

[bsipocz]

Any change that this method will be able to handle multiple IDs at the same time? I'm just asking as get_datalinks below can and as we already rename the argument we can make it a bit more self consistent and call this one ids, too.

[cosmoJFH]

Yes, we have a task to update this method to handle multiple IDs at the same time, but this will part of our next sprint. So, would it be convenient to to change source_id by ids now. instead of of id? Or better to do it in the PR where the changes would be implemented?

[bsipocz]

I would say it's better to change it now, so we don't need to change it again when the functionality is extended.

[cosmoJFH]

We have changed the parameter source_id to ids.