Skip to content

Add get_zeropoint and more flexible metadata querying to SVO FPS#3545

Open
keflavich wants to merge 7 commits intoastropy:mainfrom
keflavich:svo_fps-zeropoint
Open

Add get_zeropoint and more flexible metadata querying to SVO FPS#3545
keflavich wants to merge 7 commits intoastropy:mainfrom
keflavich:svo_fps-zeropoint

Conversation

@keflavich
Copy link
Contributor

There is metadata on SVO FPS that is inaccessible but should be.

#3528 showed the right mechanism to retrieve metadata, but it didn't allow querying on PhotCalID - while data_from_svo allowed specification of this parameter, the mechanism we are using to parse the votable drops the relevant data.

This PR adds a new get_zeropoint mechanism to very explicitly and cleanly retrieve zeropoints and also generalizes get_filter_metadata.

Note that I have made some serious mistakes in recent publications because I failed to realize the default zeropoint was vega, so it's high importance for me to expose the get_zeropoint method with an explicit mag_sys keyword to users.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 72.72%. Comparing base (b1cae75) to head (bb82061).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/svo_fps/core.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3545      +/-   ##
==========================================
+ Coverage   72.66%   72.72%   +0.06%     
==========================================
  Files         219      219              
  Lines       20480    20489       +9     
==========================================
+ Hits        14882    14901      +19     
+ Misses       5598     5588      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bsipocz bsipocz added this to the 0.4.12 milestone Mar 3, 2026
Copy link
Member

@cgobat cgobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants