Add get_zeropoint and more flexible metadata querying to SVO FPS#3545
Open
keflavich wants to merge 7 commits intoastropy:mainfrom
Open
Add get_zeropoint and more flexible metadata querying to SVO FPS#3545keflavich wants to merge 7 commits intoastropy:mainfrom
keflavich wants to merge 7 commits intoastropy:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3545 +/- ##
==========================================
+ Coverage 72.66% 72.72% +0.06%
==========================================
Files 219 219
Lines 20480 20489 +9
==========================================
+ Hits 14882 14901 +19
+ Misses 5598 5588 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is metadata on SVO FPS that is inaccessible but should be.
#3528 showed the right mechanism to retrieve metadata, but it didn't allow querying on PhotCalID - while
data_from_svoallowed specification of this parameter, the mechanism we are using to parse the votable drops the relevant data.This PR adds a new
get_zeropointmechanism to very explicitly and cleanly retrieve zeropoints and also generalizesget_filter_metadata.Note that I have made some serious mistakes in recent publications because I failed to realize the default zeropoint was vega, so it's high importance for me to expose the
get_zeropointmethod with an explicitmag_syskeyword to users.