Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3548 +/- ##
=======================================
Coverage 72.66% 72.67%
=======================================
Files 219 219
Lines 20480 20483 +3
=======================================
+ Hits 14882 14885 +3
Misses 5598 5598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
af59414 to
520556d
Compare
bsipocz
left a comment
There was a problem hiding this comment.
This looks good to me.
I'll keep the PR open though for a little while to allow others to chime in if they want.
|
Just FYI that https://astroconda.org/ needs a SSL cert refresh (cc @jhunkeler) so some |
Yeap, those are failing for a while. Feel free to skip them altogether; merging this PR kinds of makes off hands off of the module so no need to burn CI resources on it. |
|
The SSL should be fixed now FWIW. In the future, when this is actually removed, and the removal is released, we want to shut down |
ManonMarchand
left a comment
There was a problem hiding this comment.
LGTM. Do we want a link to PyVO's SCS in the warning message?
If the URL isn't terribly long, perhaps. Otherwise, it might make the message too ugly to read. I included link in user doc. |
Close #2027
After merge:
Open follow-up issue to remove-- no need; we don't normally open such follow-up issues.vo_conesearchcompletely after deprecation period has elapsed.