Skip to content

API: Deprecate vo_conesearch#3548

Open
pllim wants to merge 1 commit intoastropy:mainfrom
pllim:deprecate_vo_conesearch
Open

API: Deprecate vo_conesearch#3548
pllim wants to merge 1 commit intoastropy:mainfrom
pllim:deprecate_vo_conesearch

Conversation

@pllim
Copy link
Member

@pllim pllim commented Mar 4, 2026

Close #2027

After merge:

  • Open follow-up issue to remove vo_conesearch completely after deprecation period has elapsed. -- no need; we don't normally open such follow-up issues.
  • Open follow-up issue to write up a transition guide, if there is a need for it. -- edit by Brigitta: I would also just open this issue if the need arises, not before.

@pllim pllim requested review from ManonMarchand and bsipocz March 4, 2026 21:11
@pllim pllim added this to the 0.4.12 milestone Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.67%. Comparing base (b1cae75) to head (520556d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3548   +/-   ##
=======================================
  Coverage   72.66%   72.67%           
=======================================
  Files         219      219           
  Lines       20480    20483    +3     
=======================================
+ Hits        14882    14885    +3     
  Misses       5598     5598           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim force-pushed the deprecate_vo_conesearch branch from af59414 to 520556d Compare March 4, 2026 21:21
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

I'll keep the PR open though for a little while to allow others to chime in if they want.

@pllim
Copy link
Member Author

pllim commented Mar 4, 2026

Just FYI that https://astroconda.org/ needs a SSL cert refresh (cc @jhunkeler) so some vo_conesearch remote data tests are failing because of that.

@bsipocz
Copy link
Member

bsipocz commented Mar 4, 2026

Just FYI that astroconda.org needs a SSL cert refresh (cc @jhunkeler) so some vo_conesearch remote data tests are failing because of that.

Yeap, those are failing for a while. Feel free to skip them altogether; merging this PR kinds of makes off hands off of the module so no need to burn CI resources on it.

@pllim
Copy link
Member Author

pllim commented Mar 4, 2026

The SSL should be fixed now FWIW.

In the future, when this is actually removed, and the removal is released, we want to shut down astroconda.org for good. Hope that is not a problem.

Copy link
Member

@ManonMarchand ManonMarchand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we want a link to PyVO's SCS in the warning message?

@pllim
Copy link
Member Author

pllim commented Mar 5, 2026

a link to PyVO's SCS

If the URL isn't terribly long, perhaps. Otherwise, it might make the message too ugly to read. I included link in user doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNT: Have a plan to retire vo_conesearch

3 participants