Skip to content

Added a method to HeasarcClass that returns the number of rows in a named catalog#3549

Open
DavidT3 wants to merge 6 commits intoastropy:mainfrom
DavidT3:main
Open

Added a method to HeasarcClass that returns the number of rows in a named catalog#3549
DavidT3 wants to merge 6 commits intoastropy:mainfrom
DavidT3:main

Conversation

@DavidT3
Copy link

@DavidT3 DavidT3 commented Mar 5, 2026

A small convenience method has been included in the HeasarcClass class which takes the name of a catalog as an argument and passes it to a simple ADQL query that uses COUNT(*) to fetch the number of rows it contains.

The integer number of rows is then extracted from that return, and passed back to the user.

This abstracts another use of ADQL away from the user.

A simple test was added, and an example in the Heasarc sub-module docs.

David Turner added 4 commits March 5, 2026 14:01
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.65%. Comparing base (b1cae75) to head (6ae40c1).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
astroquery/heasarc/core.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3549      +/-   ##
==========================================
- Coverage   72.66%   72.65%   -0.01%     
==========================================
  Files         219      219              
  Lines       20480    20484       +4     
==========================================
+ Hits        14882    14883       +1     
- Misses       5598     5601       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant