WIP/proposal: plotting for compound artists#470
Draft
keflavich wants to merge 1 commit intoastropy:mainfrom
Draft
WIP/proposal: plotting for compound artists#470keflavich wants to merge 1 commit intoastropy:mainfrom
keflavich wants to merge 1 commit intoastropy:mainfrom
Conversation
Member
There was a problem hiding this comment.
I think this approach may be the best we can do. One issue is that the returned patches will represent each component of the compound shape instead of single patch/path representing the outline of the compound shape. But I think it would be challenging to implement that in a general way for all possible compound shapes.
Contributor
Author
|
Yeah, that's where I landed on this. It's been a while since I worked on this PR - I think I was waiting for your go-ahead before doing any more work, but probably all that's needed are some tests & documentation? (...which is twice as much as what's already here...) |
Member
|
Yeah, docs and tests are needed. Also, an example with a plot would be helpful, also explaining the caveats above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #469. A little more documentation, and some testing, is needed.
@larrybradley what do you think of this general approach?
.plotstays transparent to users (though now can return lists), butCompositeregions behave differently from other regions by default (except for annuli, which already have their own special case).