This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Scroll when pressing keyboard (pageup/pagedown/up/down/home/end)#53
Open
liuderchi wants to merge 1 commit intoatom:masterfrom
Open
Scroll when pressing keyboard (pageup/pagedown/up/down/home/end)#53liuderchi wants to merge 1 commit intoatom:masterfrom
liuderchi wants to merge 1 commit intoatom:masterfrom
Conversation
liuderchi
force-pushed
the
keypress_navigation
branch
2 times, most recently
from
da15f2a to
f963008
Compare
liuderchi
changed the title
liuderchi
force-pushed
the
keypress_navigation
branch
from
f963008 to
6e6e84f
Compare
Contributor
|
Works as advertised. 👍 |
liuderchi
force-pushed
the
keypress_navigation
branch
2 times, most recently
from
360bf48 to
e5eac95
Compare
liuderchi
force-pushed
the
keypress_navigation
branch
from
e5eac95 to
24061cb
Compare
liuderchi
force-pushed
the
keypress_navigation
branch
from
24061cb to
2da25c7
Compare
liuderchi
force-pushed
the
keypress_navigation
branch
from
2da25c7 to
99a09d8
Compare
Author
|
rebase onto master to resolve merge conflicts |
liuderchi
force-pushed
the
keypress_navigation
branch
2 times, most recently
from
66d2ed9 to
0b8deff
Compare
liuderchi
force-pushed
the
keypress_navigation
branch
2 times, most recently
from
68f430b to
69d3d42
Compare
Author
|
rebase onto master to resolve conflicts (decaf styleguide.coffee -> styleguide.js) |
liuderchi
force-pushed
the
keypress_navigation
branch
2 times, most recently
from
c8d054b to
d429370
Compare
- use dom-listener to handle keydown event - add styleguideView, domListener in styleguide.coffee - add onKeyDownScroll() to change scrollTop property in styleguide-view.js
liuderchi
force-pushed
the
keypress_navigation
branch
from
d429370 to
33bfaf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
require one additional package:
dom-listener: ^0.1.2Description of the Change
dom-listenerto handle keydown eventstyleguideView,domListenerto keep reference of view and DOM listeneronKeyDownScroll()to changescrollTopproperty instyleguide-view.jskeyCodeToScrollStepproperty for storing mapping of key code to scroll stepBenefits
this PR enable user to scroll in styleguide by pressing
pageup,pagedown,home,end,up,downPossible Drawbacks
Applicable Issues
issue #51