Draft
Conversation
As the title suggest, this PR adds an exception to the veto msg from the oversight DAO to prevent the DAO from vetoing a proposal that changes it to a new address, which might configure a scenario of abuse of power.
Reorder some of the calls in the ante to: 1) verify signature before doing any tx-related stateful check 2) deduct fee also before doing any tx-related stateful check (but after the sig verification)
as per the title, there were some missing fields in the converters, both in the main params as well as the deposit throttlers
Closes: #242 Proceed to do the v4 upgrades verification and implements possible missing migrations. ```sh ATOMONED_BIN=./build/atomoned-v3 ATOMONED_NEW_BIN=./build/atomoned ./contrib/scripts/upgrade-node.sh ``` --- ``` error during handshake: error on replay: collections: encoding error: value decode: proto: wrong wireType = 2 for field QuorumCheckCount ``` --------- Co-authored-by: Thomas Bruyelle <thomas.bruyelle@tendermint.com>
The `LastStatusChangeTime` field was left out of the conversion. This is a really minor issue due to the fact that the field is for internal use, but for completeness, this PR adds it to the converters.
Due to the presence of the wrapper, vote messages from cosmos sdk gov are still accepted but in the current ante are not subject to the same minimum stake requirement as atomone gov messages. This PR adds the missing filters in the gov ante.
Bump to tagged versions of the cosmos sdk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires VAAS provider (allinbits/vaas#18) in provider.
To be used in allinbits/gno-realms#11, as the e2e are using AtomOne.