fix(coredaos): prevent veto of a proposal that disables the Oversight DAO#299
Open
fix(coredaos): prevent veto of a proposal that disables the Oversight DAO#299
Conversation
giunatale
requested review from
giuliostramondo,
jaekwon and
tbruyelle
as code owners
tbruyelle
approved these changes
Mar 17, 2026
Pantani
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup of #275 where however disabling the oversight DAO (by setting the param to an empty string) could still be vetoed. In practice, it's better if no changes to the oversight DAO can be vetoed to prevent annoying scenarios.
While this specific circumstance could be countered by first electing a pro-tempore Oversight DAO that would not veto it's removal and then disable the Oversight DAO by setting the param to an empty string, this PR addresses the issue altogether.