fix(gov): preserve SDK-only params in legacy updates and use SDK cancel defaults in v4#303
Open
fix(gov): preserve SDK-only params in legacy updates and use SDK cancel defaults in v4#303
Conversation
…el defaults in v4
Pantani
requested review from
giuliostramondo,
giunatale,
jaekwon and
tbruyelle
as code owners
Collaborator
|
Is it related to an audit finding ? |
Collaborator
|
This seems to clash with #306 which was fixing A-35. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two gov compatibility issues:
Without this fix, the backward-compatibility wrapper for legacy gov param updates could fail SDK validation, and the v4 migration would diverge from SDK default proposal-cancel behavior.