Performance Optimization: Enable Dataset Caching#39
Open
austrian-code-wizard wants to merge 1 commit intomainfrom
Open
Performance Optimization: Enable Dataset Caching#39austrian-code-wizard wants to merge 1 commit intomainfrom
austrian-code-wizard wants to merge 1 commit intomainfrom
Conversation
- Remove load_from_cache_file=False from all dataset.map() calls - Enables HuggingFace datasets built-in caching mechanism - Significantly improves performance for repeated dataset operations - Add comprehensive performance optimization report documenting 7+ inefficiencies Co-Authored-By: moritz.stephan01+0622@gmail.com <moritz.stephan01+0622@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance Optimization: Enable Dataset Caching
Summary
This PR implements a high-impact performance optimization by enabling dataset caching in the C3PO pipeline. The change removes
load_from_cache_file=Falseparameters from alldataset.map()calls, allowing HuggingFace datasets to use their built-in caching mechanism.Changes Made
load_from_cache_file=Falsefrom 13 dataset transformation calls insrc/dataset/format.pyPERFORMANCE_OPTIMIZATION_REPORT.mddocumenting 7+ performance inefficiencies found in the codebasePerformance Impact
Files Modified
src/dataset/format.py: Enabled caching forto_dpo(),to_lcdpo(),to_sft(), andto_sft_weighted()functionsPERFORMANCE_OPTIMIZATION_REPORT.md: Comprehensive analysis of optimization opportunitiesTesting
Additional Optimizations Identified
The performance report documents 6 additional optimization opportunities:
Link to Devin run: https://staging.itsdev.in/sessions/4be7382ca8424ed8b29365650eb98ca6
Requested by: moritz.stephan01+0622@gmail.com