Improve protobuf java deps handling#134
Merged
tstirrat15 merged 5 commits intoauthzed:mainfrom May 1, 2025
Merged
Conversation
Contributor
julianleonard123
commented
May 1, 2025
julianleonard123
commented
- Exclude conflicting transitive version of protobuf-java
- Include protobuf-java as a compile dependency to consumers can more easily compile their applications.
- Update sample code to make sure it compiles (not compileable since 0.8.0 was released)
- Update README with versions of io.grpc libraries that match gradle config.
…e we explicitly pull in a specific version on the next line anyway. This will allow for more clarity on what version will be used and avoid conflicts highlighted by tools like enforcer: org.apache.maven.enforcer.rules.dependency.DependencyConvergence
…cluded transitively in compile scope for our maven consumers. This makes the client library easier to use and avoids the end users having to include the protobuf-java dependency themselves.
…fig. Also change from importing grpc-protobuf to grpc-api since our sample code depends directly on classes in grpc-api (e.g. ManagedChannel), not on protobuf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.