Skip to content

fix definition grammar#26

Merged
tstirrat15 merged 1 commit intoauthzed:mainfrom
h3adache:fix-definition-grammar
Jan 13, 2025
Merged

fix definition grammar#26
tstirrat15 merged 1 commit intoauthzed:mainfrom
h3adache:fix-definition-grammar

Conversation

@h3adache
Copy link
Contributor

Fixes #19
The definition pattern did not match the proper definition grammar and did not allow for prefixes.
I pulled the updated pattern from tree-sitter-spicedb.

Screenshot 2025-01-10 at 12 00 27 Screenshot 2025-01-10 at 12 00 34 Screenshot 2025-01-10 at 12 00 48

@github-actions
Copy link

github-actions bot commented Jan 10, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@h3adache
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@h3adache
Copy link
Contributor Author

recheck

authzedbot added a commit to authzed/cla that referenced this pull request Jan 10, 2025
Copy link
Collaborator

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good.

@tstirrat15 tstirrat15 merged commit 551cd09 into authzed:main Jan 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
"definition": {
"comment": "definition of a resource type in schema",
"begin": "(\\bdefinition\\b)\\s+([a-zA-Z_]\\w*)\\s*(\\{)",
"begin": "(\\bdefinition\\b)\\s+(([a-z][\\w]{1,62}[a-z0-9]\\/)*[a-z][\\w]{1,62}[a-z0-9])\\s*(\\{)",
Copy link
Contributor

@miparnisari miparnisari Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't this apply to caveats too? #43

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Syntax highlighting broken if object type is namespaced with /

3 participants